Skip to content

Remove expired ThemeData deprecations #98578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 4 commits into from
Mar 10, 2022
Merged

Remove expired ThemeData deprecations #98578

fluttergithubbot merged 4 commits into from
Mar 10, 2022
+1 −143

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022

This removes

  • useTextSelectionTheme
  • textSelectionColor
  • cursorColor
  • textSelectionHandleColor

from ThemeData.

These deprecated properties have reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes a: quality A truly polished experience c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Feb 16, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Mar 3, 2022

This is waiting on the last 2 customer changes

@Piinks Piinks changed the title [WIP] Remove expired ThemeData deprecations Remove expired ThemeData deprecations Mar 4, 2022
@flutter-dashboard flutter-dashboard bot added the a: text input Entering text in a text field or keyboard related problems label Mar 4, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Mar 4, 2022

This is ready now.

@Piinks Piinks requested a review from darrenaustin March 4, 2022 18:33
darrenaustin
darrenaustin approved these changes Mar 5, 2022
View reviewed changes
Copy link
Contributor

@darrenaustin darrenaustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sweet. Thx for doing this.

@Piinks
Copy link
Contributor Author

Piinks commented Mar 7, 2022

Ack, there are still a few more references internally that I need to clean up.

@fluttergithubbot fluttergithubbot merged commit 9291c8b into flutter:master Mar 10, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
eba17b9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
c7fb50a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
b26a30b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 10, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
04b5f7e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 10, 2022
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
1278a29
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
0970e86
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
772fe0e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
7827bc6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
39f96b6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
e164ff8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
778d3d3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 14, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
0dc3a18
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
8972f79
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
ba8f57b
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
be4bffd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
fe6114c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
b1d74dd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 15, 2022
@engine-flutter-autoroll
9291c8b Remove expired ThemeData deprecations (flutter/flutter#98578)
5d650dd
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@darrenaustin darrenaustin darrenaustin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: quality A truly polished experience a: text input Entering text in a text field or keyboard related problems c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @darrenaustin @fluttergithubbot