Skip to content

Remove deprecated Scaffold SnackBar API #98549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Apr 8, 2022
Merged

Remove deprecated Scaffold SnackBar API #98549

fluttergithubbot merged 3 commits into from
Apr 8, 2022

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Feb 16, 2022

This removes the deprecated SnackBar API from the Scaffold:

  • showSnackbar
  • hideCurrentSnackbar
  • removeCurrentSnackbar

This deprecated property has reached end of life after the release of Flutter 2.10

Part of #98537
For the full list of deprecations being removed in this batch, see flutter.dev/go/deprecations-removed-after-2-10

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@Piinks Piinks added c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. c: API break Backwards-incompatible API changes a: quality A truly polished experience c: tech-debt Technical debt, code quality, testing, etc. labels Feb 16, 2022
@flutter-dashboard flutter-dashboard bot added the f: material design flutter/packages/flutter/material repository. label Feb 16, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Mar 8, 2022

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

This was referenced Apr 1, 2022
Merged
Merged
@Piinks Piinks changed the title [WIP] Remove deprecated Scaffold SnackBar API Remove deprecated Scaffold SnackBar API Apr 1, 2022
@Piinks
Copy link
Contributor Author

Piinks commented Apr 1, 2022

This should be ready to land once these land:

@Piinks Piinks force-pushed the cleanScaffold branch 2 times, most recently from 30cb28c to 594ff60 Compare April 7, 2022 18:11
gspencergoog
gspencergoog approved these changes Apr 8, 2022
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@fluttergithubbot fluttergithubbot merged commit 135bb5d into flutter:master Apr 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 8, 2022
@engine-flutter-autoroll
135bb5d Remove deprecated Scaffold SnackBar API (flutter/flutter#98549)
d820d92
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Apr 9, 2022
@engine-flutter-autoroll
135bb5d Remove deprecated Scaffold SnackBar API (flutter/flutter#98549)
85cd39b
@Piinks Piinks mentioned this pull request Apr 13, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees

No one assigned

Labels

a: quality A truly polished experience c: API break Backwards-incompatible API changes c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Piinks @gspencergoog @fluttergithubbot