Improve container widget by r-mzy47 · Pull Request #98389 · flutter/flutter

r-mzy47 · 2022-02-14T07:58:41Z

in Container Widget when the child parameter is null and constraints is not Tight, there is no need to add the [Align] widget when the alignment parameter is provided.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
All existing and new tests are passing.

goderbauer

LGTM

Piinks

Hey @r-mzy47 welcome! Thanks for the contribution!
LGTM

goderbauer · 2022-03-02T22:48:48Z

@r-mzy47 Looks like the tests got stuck on this PR and for some reason I cannot restart them. Could you push and empty commit to this PR or rebase it to the latest master to re-trigger the tests? Thanks and sorry for the inconvenience.

fluttergithubbot · 2022-03-03T08:01:20Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_0 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_1 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_2 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_5 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_6 has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Linux web_canvaskit_tests_7_last has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

r-mzy47 · 2022-03-04T13:28:54Z

@goderbauer I have pushed an empty commit. But still, there are some pending tests. In addition, there are some failures added. have I done something wrong?

goderbauer · 2022-03-04T18:19:48Z

Looks like its an unrelated failure. Should be fixed if you rebase this branch to the latest master.

…ers are null

goderbauer

LGTM

flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 14, 2022

goderbauer reviewed Feb 16, 2022

View reviewed changes

Comment thread packages/flutter/lib/src/widgets/container.dart Outdated

r-mzy47 requested a review from goderbauer February 18, 2022 15:16

goderbauer approved these changes Feb 23, 2022

View reviewed changes

Piinks approved these changes Feb 24, 2022

View reviewed changes

Piinks added the waiting for tree to go green label Feb 24, 2022

fluttergithubbot removed the waiting for tree to go green label Mar 3, 2022

r-mzy47 requested review from CaseyHillers and keyonghan as code owners March 4, 2022 20:36

r-mzy47 added 13 commits March 5, 2022 00:32

Container: remove [Align] widget when child, width and height paramet…

9ecc1b3

…ers are null

add test

3fd5012

add brackets

6b903a1

edit test description

7020cf8

remove extra spaces

ef46f4a

fix: add nullcheck to alignment

6cf95f0

empty commit

24f1770

add test

6ef21cc

add brackets

a625308

edit test description

811c767

remove extra spaces

82b0416

fix: add nullcheck to alignment

da90502

empty commit

bac15fe

r-mzy47 force-pushed the improve-container-widget branch from 2e6805b to bac15fe Compare March 4, 2022 21:07

r-mzy47 requested a review from goderbauer March 4, 2022 22:40

goderbauer approved these changes Mar 4, 2022

View reviewed changes

goderbauer added the waiting for tree to go green label Mar 4, 2022

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 8f5b5492bed2 (82 revisions) flutter/packages#1107

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

bf50793

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to a491a81f7873 (83 revisions) flutter/packages#1108

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

6dfb99d

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 66826e8fefb9 (84 revisions) flutter/packages#1109

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

ab70592

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 4f7d7b56191d (85 revisions) flutter/packages#1110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

6bdc1e5

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 4c591bc755c4 (86 revisions) flutter/packages#1111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

9b8a38f

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 10805ca3fe6b (87 revisions) flutter/packages#1112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

127a616

engine-flutter-autoroll mentioned this pull request Mar 7, 2022

Roll Flutter from 38dbbb17f8ce to 8f58af8b8ce9 (88 revisions) flutter/packages#1113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2022

d61caaa Improve container widget (flutter/flutter#98389)

4bfcc56

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to 23ea5120d4f2 (89 revisions) flutter/packages#1114

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

d61caaa Improve container widget (flutter/flutter#98389)

29034b5

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to c188930554b7 (90 revisions) flutter/packages#1115

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

d61caaa Improve container widget (flutter/flutter#98389)

e4211da

engine-flutter-autoroll mentioned this pull request Mar 8, 2022

Roll Flutter from 38dbbb17f8ce to c15ec6a13e5d (91 revisions) flutter/packages#1116

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 8, 2022

d61caaa Improve container widget (flutter/flutter#98389)

c3109d2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Improve container widget#98389

Improve container widget#98389
fluttergithubbot merged 13 commits into
flutter:masterfrom
r-mzy47:improve-container-widget

r-mzy47 commented Feb 14, 2022 •

edited

Loading

Uh oh!

Uh oh!

goderbauer left a comment

Uh oh!

Piinks left a comment

Uh oh!

goderbauer commented Mar 2, 2022

Uh oh!

fluttergithubbot commented Mar 3, 2022

Uh oh!

r-mzy47 commented Mar 4, 2022

Uh oh!

goderbauer commented Mar 4, 2022

Uh oh!

goderbauer left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

r-mzy47 commented Feb 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Mar 2, 2022

Uh oh!

fluttergithubbot commented Mar 3, 2022

Uh oh!

r-mzy47 commented Mar 4, 2022

Uh oh!

goderbauer commented Mar 4, 2022

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

r-mzy47 commented Feb 14, 2022 •

edited

Loading