Skip to content

Dump app on keyboard_textfield_test timeout #98305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 14, 2022
Merged

Dump app on keyboard_textfield_test timeout #98305

fluttergithubbot merged 1 commit into from
Feb 14, 2022

Conversation

@LongCatIsLooong
Copy link
Contributor

@LongCatIsLooong LongCatIsLooong commented Feb 12, 2022

Help investigate #96787

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 12, 2022
jmagman
jmagman reviewed Feb 12, 2022
View reviewed changes
dev/integration_tests/ui/test_driver/keyboard_textfield_test.dart
}
}

if (!keyboardVisible) {
Copy link
Member

@jmagman jmagman Feb 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's also (await driver.getRenderTree()).tree if that's helpful at all.

jmagman
jmagman approved these changes Feb 12, 2022
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM let's see if we get anything useful.

@fluttergithubbot fluttergithubbot merged commit ad612b5 into flutter:master Feb 14, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
ad612b5 Dump app on keyboard_textfield_test timeout (flutter/flutter#…
22f4464 
…98305)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
ad612b5 Dump app on keyboard_textfield_test timeout (flutter/flutter#…
48c531c 
…98305)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
ad612b5 Dump app on keyboard_textfield_test timeout (flutter/flutter#…
89791e5 
…98305)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 14, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 14, 2022
@engine-flutter-autoroll
ad612b5 Dump app on keyboard_textfield_test timeout (flutter/flutter#…
39d5233 
…98305)
@LongCatIsLooong LongCatIsLooong deleted the keyboard-textfield-test-dump-on-fail branch February 14, 2022 17:44
@LongCatIsLooong LongCatIsLooong mentioned this pull request Feb 23, 2022
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@LongCatIsLooong @clocksmith
Dump app on keyboard_textfield_test timeout (flutter#98305)
8c6c87b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LongCatIsLooong @jmagman @fluttergithubbot