Add a BindingBase.debugBindingType() method to enable asserts that want to verify that the binding isn't initialized #98226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goderbauer
approved these changes
Feb 11, 2022
Member
There was a problem hiding this comment.
Document that calling this is only valid in debug mode and will return null in non-debug mode even when the bindings are initialized?
Contributor
Author
There was a problem hiding this comment.
oh yikes, good call, i totally forgot to mention that
Member
There was a problem hiding this comment.
lint is complaining about initializing this to null.
…nt to verify that the binding isn't initialized
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Feb 12, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
clocksmith
pushed a commit
to clocksmith/flutter
that referenced
this pull request
Mar 8, 2022
…nt to verify that the binding isn't initialized (flutter#98226)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.