Skip to content

Export activity for module in AndroidManifest.xml #98076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Feb 9, 2022
Merged

Export activity for module in AndroidManifest.xml #98076

fluttergithubbot merged 1 commit into from
Feb 9, 2022

Conversation

@blasten
Copy link

@blasten blasten commented Feb 8, 2022

This was missing in the Flutter module template, and causes an issue:

adb: failed to install apps/flutter-add-to-app/flutter_module/build/host/outputs/apk/app.apk: Failure [INSTALL_PARSE_FAILED_MANIFEST_MALFORMED: Failed parse during installPackageLI: /data/app/vmdl1999571180.tmp/base.apk
(at Binary XML file line #23): com.example.flutter_module.host.MainActivity: Targeting S+ (version 31 and above) requires that an explicit value for android:exported be defined when intent filters are present]
Error launching application on Pixel 4.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Feb 8, 2022
@flutter-dashboard
Copy link

flutter-dashboard bot commented Feb 8, 2022

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@blasten blasten assigned GaryQian and camsim99 and unassigned GaryQian and camsim99 Feb 8, 2022
@blasten blasten requested review from GaryQian and camsim99 February 8, 2022 23:07
GaryQian
GaryQian approved these changes Feb 9, 2022
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow thanks, somehow it never occurred to me to just add it in the template, I fixed this manually at least a dozen times haha.

LGTM!

@blasten blasten mentioned this pull request Feb 9, 2022
Closed
@Hixie
Copy link
Contributor

Hixie commented Feb 9, 2022

test-exempt: testing blocked on #98082

@fluttergithubbot fluttergithubbot merged commit badbe75 into flutter:master Feb 9, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
1ea5999 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
1d7be52 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
adc2170 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
e80966a 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
5dd8e49 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
293c72b 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
96127c4 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
aca9b4d 
…utter#98076)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
badbe75 Export activity for module in AndroidManifest.xml (flutter/fl…
4973185 
…utter#98076)
@blasten blasten deleted the missing_android_exported branch February 14, 2022 18:32
@blasten blasten mentioned this pull request Feb 14, 2022
Closed
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Export activity for module in AndroidManifest.xml (flutter#98076)
7d97301
@darshankawar darshankawar mentioned this pull request Mar 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camsim99 camsim99 Awaiting requested review from camsim99

1 more reviewer

@GaryQian GaryQian GaryQian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blasten @Hixie @GaryQian @camsim99 @fluttergithubbot