Skip to content

Add a benchmark for simple DisplayLists to exercise the Raster Cache's cache admission algorithm #97992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gw280 merged 5 commits into from
Feb 8, 2022
Merged

Add a benchmark for simple DisplayLists to exercise the Raster Cache's cache admission algorithm #97992

gw280 merged 5 commits into from
Feb 8, 2022

Conversation

@gw280
Copy link
Contributor

@gw280 gw280 commented Feb 8, 2022

This is an initial benchmark that allows us to track the status quo for a simple DisplayList that is cheap to rasterise but still gets cached anyway.

#86728

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@gw280 gw280 requested a review from flar February 8, 2022 00:10
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 8, 2022
keyonghan
keyonghan reviewed Feb 8, 2022
View reviewed changes
CaseyHillers
CaseyHillers approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@CaseyHillers CaseyHillers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ci.yaml lgtm

Edit: See @keyonghan comment about bringup

flar
flar approved these changes Feb 8, 2022
View reviewed changes
keyonghan
keyonghan approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@keyonghan keyonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM re .ci.yaml change.

@gw280 gw280 merged commit ff1e9b7 into flutter:master Feb 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
e6a67f1 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
73c7aba 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
079ee05 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
e19cd9f 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
e904a51 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
5b855ee 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
fb9b49d 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
18f54ed 
…r Cache's cache admission algorithm (flutter/flutter#97992)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
c798ed1 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
4994897 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
ac3c99a 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
dc6ab6a 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
052d07e 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
d42ee34 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
17cae22 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
234c535 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
7070e6f 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
e01d0fe 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
8aeec3c 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
d7d5013 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
b40df60 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
ad598c1 
…r Cache's cache admission algorithm (flutter/flutter#97992)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
ff1e9b7 Add a benchmark for simple DisplayLists to exercise the Raste…
02d951f 
…r Cache's cache admission algorithm (flutter/flutter#97992)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@clocksmith
Add a benchmark for simple DisplayLists to exercise the Raster Cache'…
dcfc640 
…s cache admission algorithm (flutter#97992)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flar flar flar approved these changes

+2 more reviewers

@CaseyHillers CaseyHillers CaseyHillers approved these changes

@keyonghan keyonghan keyonghan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gw280 @CaseyHillers @flar @keyonghan