-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Fix the TimePicker hour/minute field's input actions #97361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the TimePicker hour/minute field's input actions #97361
Conversation
darrenaustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TahaTesser thanks for the contribution.
This looks reasonable, but I think it could be simplified by not creating and managing the focus nodes. in the _TimePickerInputState. See my comments below. Thx.
873fd7a to
532fab1
Compare
5ec3671 to
0e17174
Compare
|
@darrenaustin Can you please take a look? Thank you! |
guidezpl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
Any objections @darrenaustin ?
|
Waiting for @darrenaustin's confirmation too before merging this, thanks. |
0e17174 to
979bbee
Compare
darrenaustin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yikes, so sorry for the lag on this. LGTM. Thx!
fixes #68249
minimal code sample
Native behavior with input mode
The hour text field has the "next" input action which shifts the focus from the hour field to the minute field.
The minute text field has the "done" input action, which hides the keyboard.
native_test.mov
Bug
Both hour and minute text fields have "done" action which when pressing does nothing.
Screen.Recording.2022-05-02.at.00.16.06.mov
Fix
Screen.Recording.2022-05-02.at.00.16.40.mov
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.