Populate PUB_ENVIRONMENT for initial pub get and correctly detect APPVEYOR as bot #9725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hixie
reviewed
May 2, 2017
bin/flutter
Outdated
|
|
||
| echo Building flutter tool... | ||
| (cd "$FLUTTER_TOOLS_DIR"; "$PUB" upgrade --verbosity=error --no-packages-dir) | ||
| pub_env="flutter_install:$PUB_ENVIRONMENT" |
Contributor
There was a problem hiding this comment.
looks like all the other variables are uppercase, we may want to be consistent.
not that we have a bash style guide other than "not use bash". :-)
Hixie
reviewed
May 2, 2017
bin/flutter.bat
Outdated
| ECHO Updating flutter tool... | ||
| PUSHD "%flutter_tools_dir%" | ||
|
|
||
| REM Makes changes to PUB_ENVIRONMENT only visiable to commands within SETLOCAL/ENDLOCAL |
Contributor
|
|
kevmoo
approved these changes
May 2, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9668