Skip to content

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented May 1, 2017

Broken by 89af5ec.

@cbracken cbracken requested review from xster and yjbanov May 1, 2017 21:09
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented May 1, 2017

LGTM but bonus points for making the logs make this failure mode much more obvious

@cbracken
Copy link
Member Author

cbracken commented May 1, 2017

Looks like there's an adb pm list packages command that ostensibly lists all packages. We can filter that for and report 'no such package' on device. I'll put together a follow-up patch.

@cbracken cbracken merged commit ffa8483 into flutter:master May 1, 2017
@cbracken cbracken deleted the hw_test branch May 1, 2017 21:18
@cbracken
Copy link
Member Author

cbracken commented May 1, 2017

Filed #9706

Hixie added a commit that referenced this pull request May 2, 2017
Hixie added a commit that referenced this pull request May 2, 2017
…9719)

* Revert "Document ScrollController (#9705)"

This reverts commit ff8609f.

* Revert "Fix channels integration test (#9713)"

This reverts commit aace622.

* Revert "Fix flutter view project's automated tests (#9712)"

This reverts commit 1a4bf9b.

* Revert "Update hello_world_memory_test package name (#9704)"

This reverts commit ffa8483.

* Revert "Increment the flutter package version (#9699)"

This reverts commit 3b237a8.

* Revert "Don’t pod unless there are plugins (#9701)"

This reverts commit 732f79e.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants