Skip to content

[Icons] Prevent double underscores after replacement#96904

Merged
guidezpl merged 3 commits into
flutter:masterfrom
guidezpl:double-underscore
Jan 30, 2022
Merged

[Icons] Prevent double underscores after replacement#96904
guidezpl merged 3 commits into
flutter:masterfrom
guidezpl:double-underscore

Conversation

@guidezpl

@guidezpl guidezpl commented Jan 20, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

Some replacements result in double underscores for a small number of icons (7 currently). Handle this case.

Not technically breaking, and since this was only in the framework for a relatively short amount of time, I'm avoiding adding 7 Dart fixes.

#94894

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 20, 2022
@guidezpl guidezpl merged commit 6bd0b95 into flutter:master Jan 30, 2022
@guidezpl guidezpl deleted the double-underscore branch January 30, 2022 12:16
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jan 30, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 30, 2022
@engine-flutter-autoroll
6bd0b95 [Icons] Prevent double underscores after replacement (flutter…
97f7f81 
…/flutter#96904)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
@engine-flutter-autoroll
6bd0b95 [Icons] Prevent double underscores after replacement (flutter…
9ed37f6 
…/flutter#96904)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@guidezpl @clocksmith
[Icons] Prevent double underscores after replacement (flutter#96904)
f5ef057 
* Prevent double underscores after replacement

* add test

* remove trailing space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@clocksmith clocksmith clocksmith approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@guidezpl @clocksmith