Skip to content

Fix autofill eligibility check#95210

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
LongCatIsLooong:autofill-fix
Jan 4, 2022
Merged

Fix autofill eligibility check#95210
fluttergithubbot merged 1 commit into
flutter:masterfrom
LongCatIsLooong:autofill-fix

Conversation

@LongCatIsLooong

@LongCatIsLooong LongCatIsLooong commented Dec 13, 2021

Copy link
Copy Markdown
Contributor

Fixes #94043.

Thanks to @morvagergely for filing the issue and providing a solution.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. labels Dec 13, 2021
justinmc
justinmc approved these changes Dec 13, 2021
View reviewed changes

@justinmc justinmc left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I think the failures may be irrelevant.

@LongCatIsLooong

LongCatIsLooong commented Dec 14, 2021

Copy link
Copy Markdown
Contributor Author

Verified on my phone that autofill works after applying this patch.

@ob-juliandixon ob-juliandixon mentioned this pull request Dec 17, 2021
Closed
@Oleh-Sv

Oleh-Sv commented Dec 29, 2021

Copy link
Copy Markdown
Contributor

@LongCatIsLooong I see PR already has approved. What are we waiting?

@AlirezaDaryani

AlirezaDaryani commented Jan 4, 2022

Copy link
Copy Markdown

So?

@AlirezaDaryani AlirezaDaryani mentioned this pull request Jan 4, 2022
Closed
@fluttergithubbot

fluttergithubbot commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite customer_testing-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot merged commit f268f82 into flutter:master Jan 4, 2022
@LongCatIsLooong LongCatIsLooong deleted the autofill-fix branch January 5, 2022 02:13
@maheshj01 maheshj01 mentioned this pull request Feb 2, 2022
Closed
itsjustkevin added a commit that referenced this pull request Feb 9, 2022
@itsjustkevin @LongCatIsLooong
[flutter_releases] Flutter stable 2.10.1 Framework Cherrypicks (#98091)
db747aa 
* Fix autofill eligibility check (#95210)

* 'add branch flutter-2.8-candidate.16 to enabled_branches in .ci.yaml'

* 'Update Engine revision to ab46186 for stable release 2.10.1'

* remove reference to enabled_branch

* update canvaskit version

* remove trailing line from canvaskit.version

Co-authored-by: LongCatIsLooong <31859944+LongCatIsLooong@users.noreply.github.com>
Co-authored-by: Kevin Chisholm <kevinjchisholm@google.com>
@RidTheRabbit RidTheRabbit mentioned this pull request Feb 16, 2023
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinmc justinmc justinmc approved these changes

Assignees

No one assigned

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Autofill not working on latest master

5 participants

@LongCatIsLooong @Oleh-Sv @AlirezaDaryani @fluttergithubbot @justinmc