Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 29, 2021

Manual roll of #94352: https://ci.chromium.org/p/flutter/builders/try/Linux%20flutter_plugins/17705

See conversation in #94369

flutter/plugins@1e2ffdb...6bc9a2b

2021-11-29 maurits@baseflow.com [webview_flutter] Clean up prefer_const_constructor ignore statements (flutter/plugins#4553)
2021-11-29 maurits@baseflow.com [webview_flutter] Updates webview_flutter_platform_interface to version 1.5.2 (flutter/plugins#4554)
2021-11-29 maurits@baseflow.com [webview_flutter] Migrate webview_flutter_platform_interface to analysis_options.yaml (flutter/plugins#4549)
2021-11-29 stuartmorgan@google.com [url_launcher] Publish fully federated version (flutter/plugins#4536)
2021-11-28 maurits@baseflow.com [webview_flutter] Pre-emptively ignore prefer_const_constructor warning. (flutter/plugins#4550)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-plugins-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jmagman
Copy link
Member Author

jmagman commented Nov 29, 2021

Expecting Mac plugin_lint_mac to still fail, will be fixed by #94374

@jmagman
Copy link
Member Author

jmagman commented Nov 29, 2021

Linux flutter_plugins passed. https://ci.chromium.org/p/flutter/builders/try/Linux%20flutter_plugins/17705
Merging to fix one of the failing tests closing the tree.

@jmagman jmagman merged commit d2059a6 into flutter:master Nov 29, 2021
@jmagman jmagman deleted the plugins-roll branch November 29, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants