Revert "Reland Reland engine display features" #93204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9038fac.
Member
Author
|
/cc @blasten @andreidiaconu The Engine roll is super backed up on #93226 and #93225. Please hold off on re-landing this work until the Engine backlog has cleared. Sorry for the inconvenience! |
Contributor
|
Third time's a charm 👍. Please let me know if I can help in any way. |
andreidiaconu
added a commit
to andreidiaconu/flutter
that referenced
this pull request
Nov 8, 2021
)" This reverts commit 2468f31.
8 tasks
Contributor
Member
Author
|
I should have noted this originally, but the remaining failure on CI that led to the reverts was just this one: If you know how to keep that one from failing again, then I think you can try to reland. |
Contributor
|
Ok, I fixed that one in #93240 and I think we are ready to try and reland. |
WizzXu
pushed a commit
to WizzXu/flutter
that referenced
this pull request
Nov 19, 2021
This reverts commit 9038fac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #93117
Really sorry about this, but the Engine roll is 40+ commits behind, and other failures are being masked by this one. I'm going to start getting the trees untangled by rolling this back along with the companion change in the Engine: flutter/engine#29574