Skip to content

Conversation

@HansMuller
Copy link
Contributor

Reverts #92297

The name of the new public AppModel class introduced by #92297 is also used by apps that depend on Flutter. We'll have to pick a less attractive name.

See internal Google issue b/205305674

@flutter-dashboard flutter-dashboard bot added d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos documentation f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Nov 5, 2021
@google-cla google-cla bot added the cla: yes label Nov 5, 2021
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert LGMT 👍

@skia-gold
Copy link

Gold has detected about 6 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/93161

@fluttergithubbot fluttergithubbot merged commit 0815da4 into master Nov 5, 2021
@fluttergithubbot fluttergithubbot deleted the revert-92297-app_model branch November 5, 2021 23:13
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants