Skip to content

Add my name to authors #90413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 5 commits into from
Oct 12, 2021
Merged

Add my name to authors #90413

fluttergithubbot merged 5 commits into from
Oct 12, 2021

Conversation

@caseycrogers
Copy link
Contributor

@caseycrogers caseycrogers commented Sep 20, 2021 •
edited
Loading

Adds my name to authors.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

@google-cla google-cla bot added the cla: yes label Sep 20, 2021
@caseycrogers
Copy link
Contributor Author

caseycrogers commented Sep 20, 2021

@dnfield Could you check this one too?

@Hixie Hixie mentioned this pull request Sep 20, 2021
Merged
@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Sep 27, 2021
@godofredoc godofredoc mentioned this pull request Sep 28, 2021
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Sep 29, 2021

This pull request is not suitable for automatic merging in its current state.

@dnfield
Copy link
Contributor

dnfield commented Sep 29, 2021

This needs a merge to head

This was referenced Sep 29, 2021
Merged
Closed
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 1, 2021

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Oct 7, 2021

I think this may require another update from the master branch to resolve the analyzer.

@caseycrogers
Copy link
Contributor Author

caseycrogers commented Oct 12, 2021

Merged, hopefully CI is happy this time. This has been my most challenging Flutter PR yet XD.

@fluttergithubbot fluttergithubbot merged commit ee241ec into flutter:master Oct 12, 2021
@caseycrogers caseycrogers deleted the patch-1 branch October 12, 2021 22:13
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@caseycrogers @clocksmith
Add my name to authors (flutter#90413)
21bc231
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Sep 13, 2022

Hi friends, does the AUTHORS still accept addition? I have surely contributed a few PRs to flutter, so not sure whether I can open a PR like this one and add the name?

@dnfield
Copy link
Contributor

dnfield commented Sep 13, 2022

Hi friends, does the AUTHORS still accept addition? I have surely contributed a few PRs to flutter, so not sure whether I can open a PR like this one and add the name?

Feel free to open a PR

@fzyzcjy
Copy link
Contributor

fzyzcjy commented Sep 13, 2022

@dnfield Thanks!

@fzyzcjy fzyzcjy mentioned this pull request Sep 13, 2022
Merged
8 tasks
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Sep 13, 2022

#111522 is created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@caseycrogers @fluttergithubbot @dnfield @Piinks @fzyzcjy @Hixie @goderbauer