Set BUILD_DIR and OBJROOT when determining if plugins support arm64 simulators#90088
Merged
Merged
Conversation
godofredoc
added a commit
that referenced
this pull request
Sep 30, 2021
* Set BUILD_DIR when determining if plugins support arm64 simulators (#90088) * 'Update Engine revision to 6ac856380fa4f66469552ce986edf59f65f7cd68 for stable release 2.5.2' Co-authored-by: Jenn Magder <magder@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#87244 started checking plugin Xcode build settings to see if any of them do not support arm64 simulators, so the whole app can opt out of supporting those simulators.
However, when calling
xcodebuildsome files are cached to theOBJROOTpath, which was incorrectly defaulting toios/build(which is not gitignored). Pass in the Flutterbuilddirectory instead for build settingsBUILD_DIRandOBJROOT.Add the
dgphto the iOS and macOS gitignore templates since they should never be checked in, and were the type of files being generated in the build directory.Add a directory check to
plugin_lint_macintegration test to prevent future regressions. This fails on master and passes on this PR.Fixes #89912