Revert "Make LiveTestWidgetsFlutterBinding work with setSurfaceSize and live tests" #86730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Jul 20, 2021
8 tasks
Contributor
Author
|
FYI @dkwingsmt |
Contributor
Author
|
This change broke gold, so the check probably won't resolve here. Merging to unblock PRs. |
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jul 20, 2021
…ceSize and live tests (flutter#86449)" (flutter#86730)" This reverts commit 8802e32.
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jul 22, 2021
…ceSize and live tests (flutter#86449)" (flutter#86730)" This reverts commit 8802e32. Fix pointer Trigger Build Change test to gesture detector
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #86449
This is causing golden file test issues, the images appear to be different with every test run