Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@14a9e9a...334fa80

2021-07-17 54450843+untp@users.noreply.github.com [flow] Switch to directional shadows (flutter/engine#27124)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC jsimmons@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

@skia-gold
Copy link

Gold has detected about 13 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/86596

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #86596 at sha 084b97d

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 17, 2021
@zanderso
Copy link
Member

@flar Are these changes expected? If so, please approve the diffs to unblock the roll. Thanks!

@flar
Copy link
Contributor

flar commented Jul 19, 2021

I triaged the diffs, but the github status hasn't changed (yet?). Hopefully a bot will come around and update the status soon.

@fluttergithubbot fluttergithubbot merged commit eb64852 into flutter:master Jul 19, 2021
@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-6cdb73d5-0862-43d5-967a-4454d84dec47-1626493128 branch July 24, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants