[flutter_tools] dont use SETLOCAL ENABLEDELAYEDEXPANSION unnecessarily #85288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Jun 25, 2021
| final ProcessResult result = await processManager.run(<String>[ | ||
| fileSystem.path.join(getFlutterRoot(), 'bin', 'dart'), | ||
| fileSystem.path.join(getFlutterRoot(), 'packages', 'flutter_tools', 'test', 'integration.shard', 'variable_expansion_windows.dart'), | ||
| '"^(?!Golden).+"', |
Contributor
Author
There was a problem hiding this comment.
With SETLOCAL ENABLEDELAYEDEXPANSION the quotes are missing
|
What you got?
On Fri, Jun 25, 2021 at 12:19 AM Jonah Williams ***@***.***> wrote:
Fixes #84270 <#84270>
SETLOCAL ENABLEDELAYEDEXPANSION is not needed in the entrypoint scripts,
all of the "interesting" work was moved to shared.bat. Nevertheless, this
causes problems when passing quoted values through the flutter or dart
since they get expanded immediately because of this.
Remove the setting.
------------------------------
You can view, comment on, or merge this pull request online at:
#85288
Commit Summary
- [flutter_tools] dont use SETLOCAL ENABLEDELAYEDEXPANSION unecessarily
File Changes
- *M* bin/dart.bat
<https://github.com/flutter/flutter/pull/85288/files#diff-b6779ba5f1440d1c9379c9fb89ba8deefd1e4dd84fd4773f77d9520fb8841278>
(2)
- *M* bin/flutter.bat
<https://github.com/flutter/flutter/pull/85288/files#diff-740def3ab10b1a5784dda7835d386f6e4c522756d4bd62a44f04365cb857f38d>
(2)
- *A*
packages/flutter_tools/test/integration.shard/variable_expansion_windows.dart
<https://github.com/flutter/flutter/pull/85288/files#diff-e864958430ded01a5be421471c640bfd96de06d7c1c9bac16abd3248da71daa0>
(8)
- *A*
packages/flutter_tools/test/integration.shard/variable_expansion_windows_test.dart
<https://github.com/flutter/flutter/pull/85288/files#diff-d6469799a3c3fcbb4a244d9d84bfc1be7f88a7c6900154648d0bcc708392232c>
(21)
Patch Links:
- https://github.com/flutter/flutter/pull/85288.patch
- https://github.com/flutter/flutter/pull/85288.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#85288>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASXSBNQYOMQKMSKFZDQDK7TTUP7UDANCNFSM47JDWNUA>
.
--
Mr. Earl GrayHawthorne, Owner
Hawthorne-s Swirl Team, LLC
Home Improvement/Residential Remodeling Services
410 Oneida Place NW, WDC 20011
***@***.***
+1(202) 276-0184
|
dnfield
approved these changes
Jun 25, 2021
Contributor
Author
|
@ehawthorne821 I'm not really interested in any remodeling services thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84270
SETLOCAL ENABLEDELAYEDEXPANSIONis not needed in the entrypoint scripts, all of the "interesting" work was moved to shared.bat. Nevertheless, this causes problems when passing quoted values through the flutter or dart since they get expanded immediately because of this.Remove the setting.