import pkg:intl when DateFormat or NumberFormat is used#83122
Merged
Conversation
| ) | ||
| ..loadResources() | ||
| ..writeOutputFiles(BufferLogger.test()); | ||
| } on Exception catch (e) { |
Contributor
There was a problem hiding this comment.
similar question here, shouldn't this fail if already if an exception is thrown?
Member
Author
There was a problem hiding this comment.
I'll remove it, was just copying from the other test cases.
| ) | ||
| ..loadResources() | ||
| ..writeOutputFiles(BufferLogger.test()); | ||
| } on Exception catch (e) { |
| } | ||
|
|
||
| bool _containsPluralMessage() => _allMessages.any((Message message) => message.isPlural); | ||
| bool _requiresIntlImport() => _allMessages.any((Message message) => message.isPlural || message.placeholdersRequireFormatting); |
Contributor
There was a problem hiding this comment.
is the plan to keep adding onto this or is there a comprehensive list of intl type usage?
Member
Author
There was a problem hiding this comment.
As far as I can tell, it's a case by case decision whether a feature needs intl or not. If we add more features, this list would grow.
jonahwilliams
approved these changes
May 22, 2021
jonahwilliams
left a comment
Contributor
There was a problem hiding this comment.
LGTM with nit + question
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Jun 10, 2021
christopherfujino
added a commit
that referenced
this pull request
Jun 11, 2021
* [flutter_tools] throw a tool exit if pub cannot be run (#83293) * Re-add the removed MediaQuery.removePadding of PopupMenuButton (#82986) * import pkg:intl when DateFormat or NumberFormat is used (#83122) Co-authored-by: Jonah Williams <jonahwilliams@google.com> Co-authored-by: xubaolin <xubaolin@oppo.com> Co-authored-by: Michael Goderbauer <goderbauer@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82713.