Force LANG=en_US.UTF-8 in test runner #82308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmagman
commented
May 12, 2021
| final Map<String, String> newEnvironment = Map<String, String>.from(environment ?? <String, String>{}); | ||
| newEnvironment['BOT'] = isBot ? 'true' : 'false'; | ||
| newEnvironment['LANG'] = 'en_US.UTF-8'; | ||
| print('\nExecuting: $command in $finalWorkingDirectory with environment $newEnvironment'); |
Member
Author
There was a problem hiding this comment.
Print the entire env, including BOT and LANG. This makes it testable, and is probably just a good idea for accuracy.
| void main() { | ||
| test('BOT variable is set on bots', () { | ||
| expect(Platform.environment['BOT'], 'true'); | ||
| }, skip: true); |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't make the user set
LANGthemselves as instructed in https://github.com/flutter/flutter/wiki/Running-and-writing-tests#running-device-lab-tests-locally.Add test. Remove bot_test that's been skipped since #43149 since
BOTenv is tested in the new test.Validated
LANG=ru_RU.KOI8-R dart bin/run.dart -t hot_mode_dev_cycle_macos_target__benchmarkfailed before this PR and passed after.Fixes #54475