Skip to content

Disable CI tests that LUCI is failing (1) #43149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Oct 21, 2019
Merged

Disable CI tests that LUCI is failing (1) #43149

jonahwilliams merged 1 commit into from
Oct 21, 2019

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Oct 21, 2019

No description provided.

@fluttergithubbot fluttergithubbot added c: contributor-productivity Team-specific productivity, code health, technical debt. work in progress; do not review labels Oct 21, 2019
@Hixie Hixie marked this pull request as ready for review October 21, 2019 04:09
@Hixie Hixie changed the title Disable CI tests that LUCI is failing Disable CI tests that LUCI is failing (1) Oct 21, 2019
@codecov
Copy link

codecov bot commented Oct 21, 2019 •
edited
Loading

Codecov Report

Merging #43149 into master will decrease coverage by 1.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #43149      +/-   ##
==========================================
- Coverage   61.23%    59.9%   -1.33%     
==========================================
  Files         195      195              
  Lines       18954    18954              
==========================================
- Hits        11606    11354     -252     
- Misses       7348     7600     +252
Flag Coverage Δ
#flutter_tool 59.9% <ø> (-1.33%) ⬇️
Impacted Files Coverage Δ
packages/flutter_tools/lib/executable.dart 0% <0%> (-92.86%) ⬇️
...kages/flutter_tools/lib/src/web/web_validator.dart 0% <0%> (-75%) ⬇️
packages/flutter_tools/lib/src/desktop_device.dart 14.89% <0%> (-59.58%) ⬇️
packages/flutter_tools/lib/src/base/platform.dart 7.14% <0%> (-57.15%) ⬇️
...es/flutter_tools/lib/src/base/process_manager.dart 9.09% <0%> (-45.46%) ⬇️
...ckages/flutter_tools/lib/src/commands/analyze.dart 0% <0%> (-38.71%) ⬇️
...kages/flutter_tools/lib/src/commands/packages.dart 0% <0%> (-32.66%) ⬇️
...ckages/flutter_tools/lib/src/base/file_system.dart 42.59% <0%> (-25.93%) ⬇️
...ackages/flutter_tools/lib/src/commands/format.dart 0% <0%> (-25%) ⬇️
...tools/lib/src/commands/make_host_app_editable.dart 0% <0%> (-22.23%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c535de...c56a50a. Read the comment docs.

jonahwilliams
jonahwilliams approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Landing to fix build

@jonahwilliams jonahwilliams merged commit 584ee10 into master Oct 21, 2019
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@Hixie @Inconnu08
Disable CI tests that LUCI is failing (flutter#43149)
3fd49fa
@tvolkert tvolkert deleted the Hixie-patch-3 branch December 3, 2019 18:49
@jmagman jmagman mentioned this pull request May 12, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hixie @jonahwilliams @googlebot @fluttergithubbot