Skip to content

Remove extended attributes from entire Flutter project #81435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
May 6, 2021
Merged

Remove extended attributes from entire Flutter project #81435

fluttergithubbot merged 1 commit into from
May 6, 2021

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 29, 2021 •
edited
Loading

Revert #81342, users reported that didn't fix #80978.

Instead of just removing the Finder extended attributes from the ios directory, do it for the entire Flutter project directory since users are reporting this is related to images in an asset directory in the root of their project.

Fixes #80978

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Apr 29, 2021
@jmagman jmagman self-assigned this Apr 29, 2021
@google-cla google-cla bot added the cla: yes label Apr 29, 2021
jmagman
jmagman commented Apr 29, 2021
View reviewed changes
packages/flutter_tools/lib/src/build_system/targets/ios.dart Outdated
Copy link
Member Author

@jmagman jmagman Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts #81342.

packages/flutter_tools/lib/src/ios/mac.dart Outdated
Copy link
Member Author

@jmagman jmagman Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing from the IosProject directory, remove from the entire project directory.

packages/flutter_tools/test/general.shard/build_system/targets/ios_test.dart Outdated
Copy link
Member Author

@jmagman jmagman Apr 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts #81342.

@jmagman jmagman mentioned this pull request Apr 29, 2021
Closed
@jmagman
Copy link
Member Author

jmagman commented May 4, 2021

User confirmed this fixed their issue #80978 (comment)

christopherfujino
christopherfujino approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman
Copy link
Member Author

jmagman commented May 6, 2021

@zanderso You removed the waiting for tree to go green label?

@zanderso
Copy link
Member

zanderso commented May 6, 2021

Ah, I misunderstood a conversation I had with @godofredoc. I've added back the tag.

@jmagman jmagman mentioned this pull request May 6, 2021
Closed
@Baw-Appie Baw-Appie mentioned this pull request May 6, 2021
Closed
8 tasks
@fluttergithubbot fluttergithubbot merged commit 3e6fe49 into flutter:master May 6, 2021
@jmagman jmagman deleted the xattr branch May 6, 2021 23:36
christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request May 25, 2021
@jmagman @christopherfujino
Remove extended attributes from entire Flutter project (flutter#81435)
95260cd
@christopherfujino christopherfujino mentioned this pull request May 25, 2021
Merged
2 tasks
christopherfujino added a commit that referenced this pull request May 27, 2021
@christopherfujino @jmagman
[flutter_releases] Flutter Stable 2.2.1 Framework Cherrypicks (#83372)
02c026b 
* Remove extended attributes from entire Flutter project (#81435)
* roll engine cherrypicks

Co-authored-by: Jenn Magder <magder@google.com>
@atsansone atsansone mentioned this pull request May 23, 2023
Closed
@jmagman jmagman mentioned this pull request Apr 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

4 participants

@jmagman @zanderso @christopherfujino @fluttergithubbot