Skip to content

[flutter_releases] Flutter Dev 2.2.0-10.1.pre Framework Cherrypicks#80459

Merged
christopherfujino merged 3 commits into
flutter:flutter-2.2-candidate.10from
chris-forks:cherrypicks-flutter-2.2-candidate.10
Apr 15, 2021
Merged

[flutter_releases] Flutter Dev 2.2.0-10.1.pre Framework Cherrypicks#80459
christopherfujino merged 3 commits into
flutter:flutter-2.2-candidate.10from
chris-forks:cherrypicks-flutter-2.2-candidate.10

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Apr 14, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Scheduled Cherrypicks

Known Pre-Submit Failures

@flutter-dashboard flutter-dashboard Bot added framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 14, 2021
@google-cla google-cla Bot added the cla: yes label Apr 14, 2021
@christopherfujino christopherfujino changed the base branch from master to flutter-2.2-candidate.10 April 14, 2021 20:03
@flutter-dashboard

flutter-dashboard Bot commented Apr 14, 2021

Copy link
Copy Markdown

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino christopherfujino mentioned this pull request Apr 14, 2021
Merged
@flutter-dashboard flutter-dashboard Bot added the engine flutter/engine related. See also e: labels. label Apr 14, 2021
@christopherfujino christopherfujino requested review from jmagman, jonahwilliams and kf6gpe and removed request for jmagman April 14, 2021 23:53
@christopherfujino christopherfujino marked this pull request as ready for review April 14, 2021 23:54
jmagman
jmagman approved these changes Apr 14, 2021
View reviewed changes

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman

jmagman commented Apr 15, 2021

Copy link
Copy Markdown
Member

module_test_ios is failing with an add to app host runtime codesigning crash:
codesign_crash.txt

Exception Type:        EXC_BAD_ACCESS (Code Signature Invalid)
Exception Codes:       0x0000000000000032, 0x0000000107614000
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace CODESIGNING, Code 0x2

The top of the log says This bot does not support codesigning
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8849863879990991456/+/steps/run_module_test_ios/0/stdout

@christopherfujino christopherfujino merged commit 0941968 into flutter:flutter-2.2-candidate.10 Apr 15, 2021
@christopherfujino christopherfujino deleted the cherrypicks-flutter-2.2-candidate.10 branch April 15, 2021 19:01
@stuartmorgan-g stuartmorgan-g mentioned this pull request May 20, 2021
Closed
@jmagman jmagman mentioned this pull request Nov 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jmagman jmagman jmagman approved these changes
@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams
@kf6gpe kf6gpe Awaiting requested review from kf6gpe

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @jmagman