Automatically activate testfield in macOS when receives accessibility… #78815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmc
approved these changes
Mar 24, 2021
Contributor
justinmc
left a comment
There was a problem hiding this comment.
LGTM 👍
Are you sure this doesn't happen on Windows or Linux as well?
Also there are some test failures about the semantics tree.
| case TargetPlatform.macOS: | ||
| textSelectionControls ??= cupertinoDesktopTextSelectionControls; | ||
| handleDidGainAccessibilityFocus = () { | ||
| // macOS automatically activated the TextField when it receives |
Contributor
There was a problem hiding this comment.
Nit: "activated" => "activates" here and below.
Contributor
Author
I am not sure since I haven't tested on those devices, but we can add that fairly easy. cc @cbracken who is working on windows accessibility |
8 tasks
cbracken
added a commit
to cbracken/flutter
that referenced
this pull request
Dec 9, 2021
On Windows, like on macOS, when the accessibility focus moves onto a text field, the text field should automatically take keyboard focus for typing. Related macOS patch: flutter#78815 Issue: flutter#77838
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… focus
This matches native behavior
fixes #77835
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.