Skip to content

Refactor: use one subprojects property#77942

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
devahmedsaleh:gradle
Mar 13, 2021
Merged

Refactor: use one subprojects property#77942
fluttergithubbot merged 1 commit into
flutter:masterfrom
devahmedsaleh:gradle

Conversation

@devahmedsaleh

Copy link
Copy Markdown
Contributor

This is a refactor to use only one subprojects property in the build.gradle script.

@flutter-dashboard flutter-dashboard Bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Mar 11, 2021
@google-cla google-cla Bot added the cla: yes label Mar 11, 2021
@devahmedsaleh devahmedsaleh marked this pull request as ready for review March 11, 2021 17:50
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@jonahwilliams jonahwilliams self-requested a review March 11, 2021 21:37
@jonahwilliams

Copy link
Copy Markdown
Contributor

Could you also update the template file that generates this?

https://github.com/flutter/flutter/blob/master/packages/flutter_tools/templates/app/android-java.tmpl/build.gradle

There might be one more, I would double check in the tool templates

@devahmedsaleh

Copy link
Copy Markdown
Contributor Author

I have already updated this template and others.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants