Skip to content

Increase dart migrate integration test timeout#77192

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:migration-test-timeout
Mar 4, 2021
Merged

Increase dart migrate integration test timeout#77192
jmagman merged 1 commit into
flutter:masterfrom
jmagman:migration-test-timeout

Conversation

@jmagman

@jmagman jmagman commented Mar 4, 2021

Copy link
Copy Markdown
Member

These seem to be hovering at about a minute, and periodically flaking. Increase timeout to 90 seconds.

Fixes #77191

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. team: flakes labels Mar 4, 2021
@jmagman jmagman self-assigned this Mar 4, 2021
@google-cla google-cla Bot added the cla: yes label Mar 4, 2021
tempDir?.deleteSync(recursive: true);
}
});
group('dart migrate', () {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a group to wrap them all in the same timeout. This file is mostly a whitespace change.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman merged commit 42c9e27 into flutter:master Mar 4, 2021
@jmagman jmagman deleted the migration-test-timeout branch March 4, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tool integration shard migrate_tests are flaky

2 participants