Skip to content

Conversation

@engine-flutter-autoroll
Copy link
Contributor

flutter/engine@17f6bfc...e763e56

2021-03-01 yjbanov@google.com remove _getRRect: fixes assertion error (flutter/engine#24688)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC zra@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

@skia-gold
Copy link

Gold has detected about 1 untriaged digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/77009

@flutter-dashboard
Copy link

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #77009 at sha 2d2ffb8

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label Mar 1, 2021
@zanderso
Copy link
Member

zanderso commented Mar 1, 2021

@yjbanov for golden file diffs.

@engine-flutter-autoroll
Copy link
Contributor Author

AutoRoller is stopped; closing the active roll.

@engine-flutter-autoroll engine-flutter-autoroll deleted the flutter-engine-flutter-autoroll-e43a19ad-60b8-4dd9-8265-9597eabf79a4-1614634385 branch March 8, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants