Skip to content

Revert "NNBD integration_test" #75030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
darrenaustin merged 1 commit into from
Jan 29, 2021
Merged

Revert "NNBD integration_test" #75030

darrenaustin merged 1 commit into from
Jan 29, 2021

Conversation

@Hixie
Copy link
Contributor

@Hixie Hixie commented Jan 29, 2021

Reverts #74922

Speculative revert to fix the tree. Tree went red after this landed.

@Hixie Hixie requested a review from dnfield January 29, 2021 23:25
@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Jan 29, 2021
@google-cla google-cla bot added the cla: yes label Jan 29, 2021
goderbauer
goderbauer approved these changes Jan 29, 2021
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dnfield
dnfield approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might have been a bad merge..

@darrenaustin darrenaustin merged commit 87b0436 into master Jan 29, 2021
@darrenaustin darrenaustin deleted the revert-74922-nnbd_fuchsia branch January 29, 2021 23:46
dnfield added a commit to dnfield/flutter that referenced this pull request Jan 30, 2021
@dnfield
Revert "Revert "NNBD integration_test (flutter#74922)" (flutter#75030)"
53af56b 
This reverts commit 87b0436.
@dnfield dnfield mentioned this pull request Jan 30, 2021
Merged
8 tasks
dnfield added a commit that referenced this pull request Feb 1, 2021
@dnfield
Reland integration_test NNBD (#75074)
d309254 
* Revert "Revert "NNBD integration_test (#74922)" (#75030)"

This reverts commit 87b0436.

* fix bad merge issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

+1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Hixie @goderbauer @dnfield @darrenaustin