Skip to content

Conversation

@bkonyi
Copy link
Contributor

@bkonyi bkonyi commented Jan 26, 2021

The CFE now logs to stdout by default when compiling a program which has
non-null-safe dependencies. Since flutter_tools has not yet migrated, we
need to suppress this message when compiling the tool.

Fixes #74366

@bkonyi bkonyi requested a review from jonahwilliams January 26, 2021 17:58
@google-cla google-cla bot added the cla: yes label Jan 26, 2021
@bkonyi
Copy link
Contributor Author

bkonyi commented Jan 26, 2021

This isn't quite ready to land as it depends on the next SDK roll into the framework.

Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label Jan 26, 2021
…lding flutter_tools

The CFE now logs to stdout by default when compiling a program which has
non-null-safe dependencies. Since flutter_tools has not yet migrated, we
need to suppress this message when compiling the tool.

Fixes #74366
@bkonyi bkonyi force-pushed the disable_unsound_null_safety_tool_message branch from bf66555 to e5422d4 Compare January 26, 2021 20:45
@jonahwilliams jonahwilliams merged commit 357dcc9 into master Jan 26, 2021
@jonahwilliams jonahwilliams deleted the disable_unsound_null_safety_tool_message branch January 26, 2021 23:05
@jonahwilliams
Copy link
Contributor

@zanderso

christopherfujino pushed a commit to chris-forks/flutter that referenced this pull request Feb 3, 2021
…lding flutter_tools (flutter#74740)

The CFE now logs to stdout by default when compiling a program which has
non-null-safe dependencies. Since flutter_tools has not yet migrated, we
need to suppress this message when compiling the tool.

Fixes flutter#74366
christopherfujino added a commit that referenced this pull request Feb 3, 2021
…#75303)

* Only show devtools deep links for render overflow errors (#74916)

* Add fixes for nullOk changes (#74866)

* [flutter_tools] delete old directories when unzipping ontop of them (#74818)

Fixes #74772

stale files from previous SDKs were getting left in the cache, confusing the analyzer.

* Make flutter create --smaple null-safe (#74844)

* Suppress 'Info: Compiling without sound null safety' message when building flutter_tools (#74740)

The CFE now logs to stdout by default when compiling a program which has
non-null-safe dependencies. Since flutter_tools has not yet migrated, we
need to suppress this message when compiling the tool.

Fixes #74366

* Split tools_tests subshards into separate shards to support sub-sub-sharding (#75033)

* Adopt tool_test shard builders (#75171)

* Adopt subshard naming convention in build_tests (#75179)

* Mark tool_integration_tests not flaky (#75273)

* roll flutter/plugins to ToT to fix analysis error

* update engine hash

Co-authored-by: Kenzie Schmoll <43759233+kenzieschmoll@users.noreply.github.com>
Co-authored-by: Kate Lovett <katelovett@google.com>
Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Co-authored-by: Michael Goderbauer <goderbauer@google.com>
Co-authored-by: Ben Konyi <bkonyi@google.com>
Co-authored-by: Jenn Magder <magder@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary reference to unsound null safety

3 participants