Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Jan 25, 2021

Introduced in #70970

Fixes #70978

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Jan 26, 2021
@google-cla google-cla bot added the cla: yes label Jan 26, 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should move the tryToDelete to a teardown call so that it runs even if the test fails part of the way through.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a few more spots while I was at it.

@jmagman jmagman force-pushed the android_plugin_example_app_build_test branch from 320189f to 9399a21 Compare January 26, 2021 02:39
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jmagman jmagman merged commit 754bc4a into flutter:master Jan 26, 2021
@jmagman jmagman deleted the android_plugin_example_app_build_test branch January 26, 2021 03:23
@jmagman jmagman added the a: tests "flutter test", flutter_test, or one of our tests label Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

android_plugin_example_app_build_test is unnecessarily reserving a devicelab android device

2 participants