Skip to content

Wait for Android plugin to load before configuring plugin dependency #70970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blasten merged 2 commits into from
Nov 21, 2020
Merged

Wait for Android plugin to load before configuring plugin dependency #70970

blasten merged 2 commits into from
Nov 21, 2020

Conversation

@blasten
Copy link

@blasten blasten commented Nov 20, 2020

implementation is provided by the Android Gradle plugin. It cannot be called before the Android plugin has loaded, and registered an implementation callback.

afterEvaluate ensures that implementation is only called after this plugin loaded.

@blasten blasten requested review from ditman and xster November 20, 2020 22:19
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Nov 20, 2020
@google-cla google-cla bot added the cla: yes label Nov 20, 2020
xster
xster reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@xster xster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can we add a test?

@blasten
Copy link
Author

blasten commented Nov 21, 2020

@xster test added

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Nov 21, 2020

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite Mac build_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@blasten blasten merged commit 61dfbfe into flutter:master Nov 21, 2020
@blasten blasten deleted the after_evaluate branch November 21, 2020 02:03
jonahwilliams
jonahwilliams reviewed Nov 21, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be running in the devicelab since it does not require dedicated hardware.

@blasten
Copy link
Author

blasten commented Nov 21, 2020

I discussed adding this to LUCI with @godofredoc. Currently, it's a manual process, and cannot be done in a single PR like this one.

This would have to be done after the holidays most likely.

@jonahwilliams
Copy link
Contributor

jonahwilliams commented Nov 21, 2020

I filled #70978 to track. Its not so urgent that we need to deal with it right now

@blasten
Copy link
Author

blasten commented Nov 21, 2020

Thanks @jonahwilliams ! I know @godofredoc is on top of improving this devX.

@jmagman jmagman mentioned this pull request Jan 25, 2021
Merged
@oshtman oshtman mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xster xster xster left review comments

@ditman ditman Awaiting requested review from ditman

+1 more reviewer

@jonahwilliams jonahwilliams jonahwilliams left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blasten @fluttergithubbot @jonahwilliams @xster