Skip to content

Add details to the iOS part integration_test #74428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Jan 22, 2021
Merged

Add details to the iOS part integration_test #74428

dnfield merged 1 commit into from
Jan 22, 2021

Conversation

@letsar
Copy link
Contributor

@letsar letsar commented Jan 21, 2021

Improved the README by adding details for the iOS section.

This PR aims to fix #48600

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test exempt.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Jan 21, 2021
@goderbauer goderbauer added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Jan 22, 2021
@goderbauer goderbauer requested a review from dnfield January 22, 2021 00:15
dnfield
dnfield approved these changes Jan 22, 2021
View reviewed changes
Copy link
Contributor

@dnfield dnfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield merged commit 0a668b9 into flutter:master Jan 22, 2021
@jmagman jmagman mentioned this pull request Jun 15, 2021
Merged
@jmagman jmagman mentioned this pull request Feb 9, 2024
Merged
8 tasks
auto-submit bot pushed a commit that referenced this pull request Feb 12, 2024
@jmagman
Update integration_test iOS FTL README script to remove targeted vers…
1d25b0c 
…ion (#143248)

1. Remove `dev_target` from suggested Firebase Test Lab iOS script and use wildcard instead.
2. First run `flutter clean` before building to avoid collisions between runs.
3. Use `zip --must-match` in case the xctestrun or `Release-iphoneos` directories are missing (like ran with `--profile` instead of `--release` on purpose) to fail instead of zipping up only part of what's needed.

This came out of a discussion with FTL about these instructions and I tried to run them locally and avoided setting `dev_target`.

See also #74428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dnfield dnfield dnfield approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

E2E iOS Documentation unclear

3 participants

@letsar @dnfield @goderbauer