Relands: Migrate template to Gradle 6.7 and AGP 4.1.0#71446
Merged
blasten merged 6 commits intoflutter:masterfrom Dec 2, 2020
Merged
Relands: Migrate template to Gradle 6.7 and AGP 4.1.0#71446blasten merged 6 commits intoflutter:masterfrom
blasten merged 6 commits intoflutter:masterfrom
Conversation
Contributor
|
LGTM for the reland after the change in https://github.com/flutter/plugin_tools/pull/123 is published |
westy92
reviewed
Dec 1, 2020
| globals.printStatus( | ||
| 'The built failed likely due to AndroidX incompatibilities in a plugin. ' | ||
| 'The build failed likely due to AndroidX incompatibilities in a plugin. ' | ||
| 'The tool is about to try using Jetfier to solve the incompatibility.' |
Contributor
There was a problem hiding this comment.
Suggested change
| 'The tool is about to try using Jetfier to solve the incompatibility.' | |
| 'The tool is about to try using Jetifier to solve the incompatibility.' |
Contributor
|
I'm happy to see this coming through! 🎉 |
Author
|
@westy92 we don't necessarily target the latest version since it gets obsolete whenever a new version is released. We also don't bump the Gradle version used in Flutter to match the latest one published by Gradle or Android Gradle plugin. However, we do our best to stay up to date, and ensure backward compatibility. |
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
This was referenced Aug 5, 2021
This was referenced Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Relands Migrate template to Gradle 6.7 and AGP 4.1.0 #70808.
Fixes the regex used to detect the AGP version as this was broken, and added test cases in d63316b.
The plugins CI issue is fixed by https://github.com/flutter/plugin_tools/pull/123
Related Issues
Fixes #58247
Fixes #49438
Tests
Unit tests
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.