Skip to content

Conversation

@gspencergoog
Copy link
Contributor

Description

This removes the last couple of doc references to the Window class in the framework, so that I can re-land the engine side change that removes the Window class (flutter/engine#22505).

Related Issues

Tests

  • Docs-only change.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Nov 16, 2020
@google-cla google-cla bot added the cla: yes label Nov 16, 2020
@flutter flutter deleted a comment from flutter-dashboard bot Nov 16, 2020
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gspencergoog gspencergoog merged commit 5ddc057 into flutter:master Nov 16, 2020
@gspencergoog gspencergoog deleted the remove_window branch November 16, 2020 22:52
gspencergoog added a commit to flutter/engine that referenced this pull request Nov 18, 2020
Reland #22505, now that flutter/flutter#70637 has landed.

Removes references to dart:ui.Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate.
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
…er#22566)

Reland flutter#22505, now that flutter/flutter#70637 has landed.

Removes references to dart:ui.Window, and switch usages to PlatformDispatcher or SingletonFlutterWindow, as appropriate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants