[null-safety] implement autodetection for the web #70126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Autodetect doesn't work the same way on the web because the tool is ultimately responsible for 1) providing a separate sound or unsound dill 2) serving the precompiled sound dart_sdk.js or unsound dart_sdk.js |
zanderso
approved these changes
Nov 9, 2020
| ...?buildInfo.extraFrontEndOptions, | ||
| '--sound-null-safety', | ||
| ]; | ||
| } else { |
yjbanov
approved these changes
Nov 9, 2020
|
|
||
| /// Attempts to read the language version of a dart [file], returning | ||
| /// the entire comment. | ||
| /// The first language version where null safety was available by default |
Contributor
There was a problem hiding this comment.
Sound or unsound?
Also, nit, end with a period.
Contributor
Author
There was a problem hiding this comment.
Language versions aren't sound or unsound. Sound = all libraries have a language version gte 2.12
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Nov 13, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Nov 14, 2020
) * Update engine hash to 1.24.0-10.1.pre * [null-safety] implement null-safe autodetection for the web (#70126) Fixes #69416 Fixes #70121 * [flutter_tools] dont use autodetect enum for web (#70189) * Update engine hash for build fix and pub DEP bump Co-authored-by: Jonah Williams <jonahwilliams@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #69416
Fixes #70121
Update determineLanguageVersion to read the language version, not just as a comment. Use this to determine which runtime mode to support on the web, removing the use of autodetect enum entirely
This logic needs to expanded in the future to support the language version queries and null safety analytics