Skip to content

Fix Gallery dependencies #69344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
blasten wants to merge 2 commits into from
Closed

Fix Gallery dependencies #69344

blasten wants to merge 2 commits into from

Conversation

@blasten
Copy link

@blasten blasten commented Oct 29, 2020

Fixes #63200

@blasten blasten requested a review from liyuqian October 29, 2020 22:51
@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 29, 2020
@google-cla google-cla bot added the cla: yes label Oct 29, 2020
liyuqian
liyuqian approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten blasten force-pushed the gallery_dependencies_fix branch from 7adab17 to 1dc33d6 Compare October 29, 2020 22:59
@liyuqian
Copy link
Contributor

liyuqian commented Oct 29, 2020

Verified the fix locally with flutter build apk.

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 30, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

@blasten blasten mentioned this pull request Oct 30, 2020
Merged
@flutter-dashboard
Copy link

flutter-dashboard bot commented Nov 19, 2020

This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold.For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@blasten blasten closed this Jan 12, 2021
@blasten blasten deleted the gallery_dependencies_fix branch January 12, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blasten @liyuqian @fluttergithubbot