Skip to content

update dev/integration_tests/flutter_gallery/android/settings.gradle #63200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
CareF wants to merge 1 commit into from
Closed

update dev/integration_tests/flutter_gallery/android/settings.gradle #63200

CareF wants to merge 1 commit into from

Conversation

@CareF
Copy link
Contributor

@CareF CareF commented Aug 7, 2020

Description

The current version of dev/integration_tests/flutter_gallery is using a old settings.gradle that's not compatible with the plugins it's using, causing warning message:

Plugin project :video_player_web not found. Please update settings.gradle.
Plugin project :connectivity_macos not found. Please update settings.gradle.

Related Issues

Fixes #63199

Tests

N/A

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 7, 2020
@CareF CareF requested a review from liyuqian August 7, 2020 16:11
@liyuqian liyuqian requested a review from blasten August 10, 2020 17:40
@liyuqian
Copy link
Contributor

liyuqian commented Aug 10, 2020

@blasten last updated this gradle to its current content. This PR seems to be restoring the old gradle. Is this intended?

@blasten
Copy link

blasten commented Aug 10, 2020

It sounds like the resolved versions of video_player_web and connectivity_macos contain a android/build.gradle file. I would try to ensure that they are resolved to a version that doesn't include those files.

@CareF
Copy link
Contributor Author

CareF commented Aug 17, 2020

@cyanglaz Should we make the change here or to somewhere in the plugins repo?

@CareF
Copy link
Contributor Author

CareF commented Aug 17, 2020 •
edited
Loading

@blasten @liyuqian These packages are pin-ed since #50365 due to the plugins' breaking change:

flutter/packages/flutter_tools/lib/src/commands/update_packages.dart

Line 32 in 042fa8c

'video_player': '0.10.6', // 0.10.7 fails a gallery smoke test for toString.

Removing that version pin will break dev/integration_tests/flutter_gallery/test/smoke_test.dart. Updating files in the plugins won't help because we can't update the depended version in the framework repo.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Sep 21, 2020

This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it.

@liyuqian
Copy link
Contributor

liyuqian commented Sep 21, 2020

Regarding #63200 (comment), shall we fix the flutter gallery smoke test so we no longer needs to pin video_player? CC @jonahwilliams @zanderso @goderbauer

@blasten blasten mentioned this pull request Oct 29, 2020
Closed
@Hixie
Copy link
Contributor

Hixie commented Oct 12, 2021

Closing. It's sad that this didn't land, but at this point it's probably easier for us to do this from scratch if we decide it still need doings.

@Hixie Hixie closed this Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liyuqian liyuqian Awaiting requested review from liyuqian

@blasten blasten Awaiting requested review from blasten

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

plugin not found in dev/integration_tests/flutter_gallery

5 participants

@CareF @liyuqian @blasten @Hixie @googlebot