Skip to content

Conversation

@gw280
Copy link
Contributor

@gw280 gw280 commented Oct 19, 2020

Description

Use the new APIs introduced in flutter/engine#21933 to pass through the command line arguments on Linux.

Related Issues

#32986

Tests

None.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 19, 2020
@gw280 gw280 force-pushed the gwright-linux-cmdline branch from 3d38372 to 2323050 Compare October 19, 2020 23:43
@google-cla google-cla bot added the cla: yes label Oct 20, 2020
Copy link
Contributor

@robert-ancell robert-ancell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@gw280 gw280 requested a review from robert-ancell October 27, 2020 20:44
@gw280 gw280 requested a review from robert-ancell October 27, 2020 20:56
@gw280 gw280 requested a review from robert-ancell October 28, 2020 01:20
@robert-ancell
Copy link
Contributor

LGTM, thanks @gw280

@robert-ancell robert-ancell merged commit 678f3cb into flutter:master Oct 29, 2020
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this pull request Aug 10, 2021
jpnurmi added a commit to jpnurmi/ubuntu-desktop-installer that referenced this pull request Aug 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants