-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Update Linux template app to pass through command line arguments to the Dart entrypoint #68535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3d38372 to
2323050
Compare
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
gw280
commented
Oct 27, 2020
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
robert-ancell
requested changes
Oct 27, 2020
Contributor
robert-ancell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
packages/flutter_tools/templates/app/linux.tmpl/my_application.cc.tmpl
Outdated
Show resolved
Hide resolved
Contributor
|
LGTM, thanks @gw280 |
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Aug 10, 2021
The changes were adapted from flutter/flutter#68535.
jpnurmi
added a commit
to jpnurmi/ubuntu-desktop-installer
that referenced
this pull request
Aug 10, 2021
The changes were adapted from flutter/flutter#68535.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use the new APIs introduced in flutter/engine#21933 to pass through the command line arguments on Linux.
Related Issues
#32986
Tests
None.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.