Skip to content

Conversation

@jonahwilliams
Copy link
Contributor

Description

Now that fast-start syncs assets by default, this isn't testing anything. Retire the test

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Oct 9, 2020
@google-cla google-cla bot added the cla: yes label Oct 9, 2020
'lib/arm64-v8a/libflutter.so',
], apkFiles);

checkCollectionDoesNotContain<String>(<String>[
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you remove this line, there are no fast start specific expectations in this test.

Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Contributor Author

Landing to fix tree

@jonahwilliams jonahwilliams merged commit 3eb2335 into flutter:master Oct 9, 2020
@jonahwilliams jonahwilliams deleted the fast_start_test branch October 9, 2020 19:41
jonahwilliams pushed a commit that referenced this pull request Oct 9, 2020
jonahwilliams pushed a commit that referenced this pull request Oct 9, 2020
jonahwilliams pushed a commit that referenced this pull request Oct 9, 2020
jonahwilliams pushed a commit that referenced this pull request Oct 9, 2020
jonahwilliams pushed a commit that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants