Skip to content

Revert "Wrap PopupMenu with SafeArea to respect status bar"#67566

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-64678-popup-menu
Oct 7, 2020
Merged

Revert "Wrap PopupMenu with SafeArea to respect status bar"#67566
jonahwilliams merged 1 commit into
masterfrom
revert-64678-popup-menu

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Oct 7, 2020

Copy link
Copy Markdown
Contributor

Reverts #64678

test/material/popup_menu_test.dart:1596:37: Error: A value of type 'int?' can't be assigned to a variable of type 'int'.
    int _selectedValue = choices[0].value;
                                    ^
test/material/popup_menu_test.dart:1600:18: Error: The argument type 'MediaQuery Function(BuildContext, Widget)' can't be assigned to the parameter type 'Widget Function(BuildContext, Widget?)?'.
 - 'MediaQuery' is from 'package:flutter/src/widgets/media_query.dart' ('lib/src/widgets/media_query.dart').
 - 'BuildContext' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
 - 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
        builder: (BuildContext context, Widget child) {
                 ^
test/material/popup_menu_test.dart:1654:18: Error: The argument type 'MediaQuery Function(BuildContext, Widget)' can't be assigned to the parameter type 'Widget Function(BuildContext, Widget?)?'.
 - 'MediaQuery' is from 'package:flutter/src/widgets/media_query.dart' ('lib/src/widgets/media_query.dart').
 - 'BuildContext' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
 - 'Widget' is from 'package:flutter/src/widgets/framework.dart' ('lib/src/widgets/framework.dart').
        builder: (BuildContext context, Widget child) {
                 ^
02:14 +2967 ~12: /b/s/w/ir/k/flutter/packages/flutter/test/material/dropdown_test.dart: Having a focused element doesn't interrupt scroll when flung by touch                                          
02:14 +2968 ~12: /b/s/w/ir/k/flutter/packages

@flutter-dashboard flutter-dashboard Bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 7, 2020
@google-cla google-cla Bot added the cla: yes label Oct 7, 2020
@jonahwilliams

Copy link
Copy Markdown
Contributor Author

TBR @Piinks

@jonahwilliams jonahwilliams merged commit 5e4c86d into master Oct 7, 2020
@jonahwilliams jonahwilliams deleted the revert-64678-popup-menu branch October 7, 2020 21:58
Piinks added a commit that referenced this pull request Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant