Skip to content

Revert "migrate some material files to nullsafety" #67183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
renyou merged 1 commit into from
Oct 3, 2020
Merged

Revert "migrate some material files to nullsafety" #67183

renyou merged 1 commit into from
Oct 3, 2020

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Oct 3, 2020

Reverts #67078

This is failing tests in google. Will investigate on Monday.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Oct 3, 2020
@goderbauer
Copy link
Member Author

goderbauer commented Oct 3, 2020 •
edited
Loading

/cc @a14n @Hixie @renyou

nturgut
nturgut approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@nturgut nturgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for revert.

jonahwilliams
jonahwilliams approved these changes Oct 3, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Oct 3, 2020

cc @pcsosinski for visibility

@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 3, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@renyou
Copy link
Contributor

renyou commented Oct 3, 2020

Google testing failed because of merge conflict. I will merge this one now.

@renyou renyou merged commit a0a65fc into master Oct 3, 2020
@renyou renyou deleted the revert-67078-nnbd-material-part branch October 3, 2020 11:54
goderbauer added a commit to goderbauer/flutter that referenced this pull request Oct 5, 2020
@goderbauer
Relandi e some material files to nullsafety (flutter#67078)" (flutter…
19437ee 
…#67183)"

This reverts commit a0a65fc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@nturgut nturgut nturgut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@goderbauer @Hixie @fluttergithubbot @renyou @jonahwilliams @nturgut @googlebot