[null-safety] migrate app dependencies of flutter driver #67155
Conversation
| /// The JSON encoded [DiagnosticsNode] tree requested by the | ||
| /// [GetDiagnosticsTree] command. | ||
| final Map<String, Object> json; | ||
| final Map<String, dynamic> json; |
There was a problem hiding this comment.
The return type of the method on result is defined as:
/// Serializes this message to a JSON map.
Map<String, dynamic> toJson();
There was a problem hiding this comment.
FWIW, I would lean towards moving from dynamic to Object? everywhere rather than the other way around, but that's something we can worry about in another PR.
goderbauer
left a comment
There was a problem hiding this comment.
Code looks good, just a question about the 2.11 tags.
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.11 |
There was a problem hiding this comment.
weird, I had some problems getting vs code to show analysis warnings locally - maybe this isn't necessary?
There was a problem hiding this comment.
AFAIK, it shouldn't be necessary since you raised the SDK constraints in the pubspec?
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.11 |
| await Scrollable.ensureVisible( | ||
| target.evaluate().single, | ||
| duration: const Duration(milliseconds: 100), | ||
| alignment: scrollIntoViewCommand.alignment); |
There was a problem hiding this comment.
nit: trailing comma and ) on next line.
| // Use of this source code is governed by a BSD-style license that can be | ||
| // found in the LICENSE file. | ||
|
|
||
| // @dart = 2.11 |
|
I'm not getting these analyzer warnings locally :( |
| type_init_formals: false # https://github.com/dart-lang/linter/issues/2192 | ||
| unrelated_type_equality_checks: false # https://github.com/dart-lang/linter/issues/2196 | ||
| void_checks: false # https://github.com/dart-lang/linter/issues/2185 | ||
| unnecessary_null_comparison: false # https://github.com/dart-lang/language/issues/1018 , turned off until https://github.com/flutter/flutter/issues/61042 |
There was a problem hiding this comment.
At least that last issue is closed., so these probably need rechecking.
|
Looks like the package allowlist is wrong? or missing? I shouldn't need to enable experiment to run these tests |
|
|
https://dart-review.googlesource.com/c/sdk/+/165871 landed to add flutter_driver to the allow list earlier today, which needs to roll into flutter/engine and then flutter/flutter from there |
|
This is blocked on a "migration order" lint from g3 due to it depending on material. Is there a way to skip this lint? |
We just finished the migration of material. As soon as the last PR rolls into google, you shouldn't need to disable the lint anymore. |
)" This reverts commit e826442.
Description
Ensures all of the libraries that the application side code import are migrated to null safety. full null safety migration is blocked by json rpc 2 and a breaking change to vm service client.