Revert dispose images when done #67100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
We currently lack a test running in CanvasKit mode and exercising images. It would have been the new gallery test but that's being removed unfortunately, so we'll need to write new one. |
dnfield
added a commit
to dnfield/flutter
that referenced
this pull request
Oct 2, 2020
Changes since last time: - Test for CanvasKit image rendering (flutter#67176) - Fix CanvasKit dispose impl (flutter/engine#21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311) This reverts commit 473358d.
dnfield
added a commit
that referenced
this pull request
Oct 5, 2020
* Reland dispose images when done (#67100) Changes since last time: - Test for CanvasKit image rendering (#67176) - Fix CanvasKit dispose impl (flutter/engine#21555) - Update internal google3 customer with a problematic ImageStream Listener impl (cl/335091311, cl/335459002) This reverts commit 473358d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke CanvasKit for web.
I have to fix that in dart:ui. The HTML backend doesn't care about dispose, but CanvasKit does, and I'm not doing it right at all for that.
Reverts "docs for image disposal (#67066)"
Reverts "Dispose of images after using them (#66688)"
@Hixie @goderbauer @yjbanov
I don't know why this didn't break CI.