Conversation
PR #65873 enabled DDS for non-web Flutter applications. This change surfaced a bug where DDS would not send ServiceRegistered events to VM service clients when they subscribed to the Service stream. This would cause tools and tests that rely on these events (e.g., hot reload in VSCode) to fail. Fixes #66038.
Contributor
|
This is likely causing a whole host of other CI issues. Consider landing on red after CI has finished if the build is still red |
Contributor
Author
SGTM. I'm actually surprised nothing failed before landing... |
|
Gold has detected about 3 untriaged digest(s) on patchset 1. |
Contributor
Author
|
Merge on red to fix CI issues. |
goderbauer
pushed a commit
to goderbauer/flutter
that referenced
this pull request
Sep 18, 2020
PR flutter#65873 enabled DDS for non-web Flutter applications. This change surfaced a bug where DDS would not send ServiceRegistered events to VM service clients when they subscribed to the Service stream. This would cause tools and tests that rely on these events (e.g., hot reload in VSCode) to fail. Fixes flutter#66038.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #65873 enabled DDS for non-web Flutter applications. This change surfaced a bug where DDS would not send ServiceRegistered events to VM service clients when they subscribed to the Service stream. This would cause tools and tests that rely on these events (e.g., hot reload in VSCode) to fail.
Fixes #66038.