Skip to content

Consider the Windows app template stable#66022

Merged
jonahwilliams merged 1 commit intoflutter:masterfrom
stuartmorgan-g:windows-template-stable
Sep 17, 2020
Merged

Consider the Windows app template stable#66022
jonahwilliams merged 1 commit intoflutter:masterfrom
stuartmorgan-g:windows-template-stable

Conversation

@stuartmorgan-g
Copy link
Copy Markdown
Contributor

Description

Removes the template version from the Windows template; the API and
tooling boundary will now be considered stable, so there will no longer
be frequent breaking changes.

Also updates the link for adding desktop support to a project for all
three platforms to reflect the current location.

Related Issues

Fixes #52748

Tests

I added the following tests: Removed the tests related to template verisons

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change.

Removes the template version from the Windows template; the API and
tooling boundary will now be considered stable, so there will no longer
be frequent breaking changes.

Also updates the link for adding desktop support to a project for all
three platforms to reflect the current location.

Fixes flutter#52748
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 17, 2020
Copy link
Copy Markdown
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams jonahwilliams merged commit 50fd10f into flutter:master Sep 17, 2020
stuartmorgan-g added a commit to stuartmorgan-g/flutter that referenced this pull request Sep 18, 2020
The template is now considered stable; this warning should no longer be
printed. This should have been part of
flutter#66022
but was missed.
goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
Removes the template version from the Windows template; the API and
tooling boundary will now be considered stable, so there will no longer
be frequent breaking changes.

Also updates the link for adding desktop support to a project for all
three platforms to reflect the current location.

Fixes flutter#52748
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stabilize Windows embedding/runner boundary

3 participants