Skip to content

Flutter Stable Framework Cherrypicks 1.20.4#65787

Merged
christopherfujino merged 1 commit into
flutter:flutter-1.20-candidate.7from
chris-forks:cherrypicks-flutter-1.20-candidate.7
Sep 14, 2020
Merged

Flutter Stable Framework Cherrypicks 1.20.4#65787
christopherfujino merged 1 commit into
flutter:flutter-1.20-candidate.7from
chris-forks:cherrypicks-flutter-1.20-candidate.7

Conversation

@christopherfujino

@christopherfujino christopherfujino commented Sep 14, 2020

Copy link
Copy Markdown
Contributor

Scheduled Cherrypicks

Postsubmit Known Failures

@flutter-dashboard

Copy link
Copy Markdown

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard Bot changed the base branch from flutter-1.20-candidate.7 to master September 14, 2020 19:55
@flutter-dashboard flutter-dashboard Bot added a: internationalization Supporting other languages or locales. (aka i18n) d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Sep 14, 2020
@christopherfujino christopherfujino changed the base branch from master to flutter-1.20-candidate.7 September 14, 2020 19:55
@christopherfujino christopherfujino changed the title Cherry-pick of 020215bb4c9e8d4fbbc5522f9eeb469fa4727279 Flutter Stable Framework Cherrypicks Sep 14, 2020
@christopherfujino christopherfujino changed the title Flutter Stable Framework Cherrypicks Flutter Stable Framework Cherrypicks 1.20.4 Sep 14, 2020
@christopherfujino christopherfujino marked this pull request as ready for review September 14, 2020 21:10

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino

Copy link
Copy Markdown
Contributor Author

Tested with a physical device, LGTM

@pcsosinski pcsosinski left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

@christopherfujino christopherfujino merged commit fba99f6 into flutter:flutter-1.20-candidate.7 Sep 14, 2020
@christopherfujino christopherfujino deleted the cherrypicks-flutter-1.20-candidate.7 branch September 14, 2020 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants