Skip to content

Revert "Add observatory Bonjour service to built iOS Info.plist bundle" #65141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Sep 3, 2020
Merged

Revert "Add observatory Bonjour service to built iOS Info.plist bundle" #65141

jmagman merged 1 commit into from
Sep 3, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 3, 2020

Reverts #65138

Still seeing

stdout:             /Users/flutter/.cocoon/flutter/dev/benchmarks/macrobenchmarks/build/ios/Profile-iphoneos/Runner.app/Info.plist: Could not extract value, error: No value at that key path or invalid key path: NSBonjourServices
stdout:             ♦ plutil -insert NSBonjourServices -json ["_dartobservatory._tcp"] /Users/flutter/.cocoon/flutter/dev/benchmarks/macrobenchmarks/build/ios/Profile-iphoneos/Runner.app/Info.plist
stdout:             /Users/flutter/.cocoon/flutter/dev/benchmarks/macrobenchmarks/build/ios/Profile-iphoneos/Runner.app/Info.plist: Could not extract value, error: No value at that key path or invalid key path: NSLocalNetworkUsageDescription
stdout:             ♦ plutil -insert NSLocalNetworkUsageDescription -string Allow Flutter tools on your computer to connect and debug your application. This prompt will not appear on release builds. /Users/flutter/.cocoon/flutter/dev/benchmarks/macrobenchmarks/build/ios/Profile-iphoneos/Runner.app/Info.plist

I missed macrobenchmarks in #65124.

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 3, 2020
@jmagman jmagman merged commit 259deec into master Sep 3, 2020
@jmagman jmagman deleted the revert-65138-bonjour-service branch September 3, 2020 01:31
@jmagman
Copy link
Member Author

jmagman commented Sep 3, 2020

Wait never mind those aren't errors, that's just some logging and these tests are flaky. Re-landing this.

jmagman added a commit that referenced this pull request Sep 3, 2020
@jmagman
Revert "Revert "Add observatory Bonjour service to built iOS Info.pli…
8030cf6 
…st bundle (#65138)" (#65141)"

This reverts commit 259deec.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (
aef74cf 
flutter#65138)" (flutter#65141)

This reverts commit 5e0aa8b.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @googlebot