Revert "A benchmark test case for measuring scroll smoothness" #64883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 12b7355.
Contributor
|
Most likely as I mentioned in #61998 (comment) the change we need is to update the build system information in |
Contributor
|
#64885 is probably not a minimum updates but if my theory is correct it should fix the issue. |
Contributor
Author
|
I'm going to move ahead with the revert for now even though despite the potential solution through #64885 because I'm not sure how I would verify that this will make the tree green again. This is also so that I can unblock some code I'm trying to get into the framework, so I hope that's okay with you! |
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…r#61998)" (flutter#64883) This reverts commit 12b7355.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #61998. This change seems to be causing some of the iOS layout/scrolling benchmarks to fail.
TBR cc/ @CareF @liyuqian. Also, do we know if it's possible to share test failure logs with non-Googlers? It seems like it would be fairly important for @CareF to be able to examine the logs if they would like to fix their PR to get the tests passing normally.